Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devcontainer.json #86

Open
wants to merge 54 commits into
base: 7.1
Choose a base branch
from
Open

Conversation

norbertosus
Copy link

No description provided.

symfonyaml and others added 30 commits June 3, 2024 08:08
… with arrays (symfonyaml)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

[Console] Better error handling when misuse of `ArgvInput` with arrays

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #53836
| License       | MIT

### Issue
When we don't use `ArgvInput` correclty, and use array in $argv values, it returns different PHP fatal errors.
See all details and how to reproduce it in the issue symfony/symfony#53836

### Solution
In this PR
 - Add some DX with an exception explaining the problem, to avoid PHP fatal errors
 - Add tests**

_____
Note : Old PR #54147 was targeting 5.4, see [this comment](symfony/symfony#54147 (comment)) for more details

Commits
-------

6f64cf4f80 [Console] Better error handling when misuse of `ArgvInput` with arrays
* 7.1:
  Allow service locators to be ordered by priority.
  [Filesystem][Mime] Fix transient tests
  Test convert CompletionInput into string
* 7.1:
  be explicit about the signal to reset
  fix Finder test using the ftp wrapper by switching the server being used
  use firewall-specific user checkers when manually logging in users
This PR was merged into the 7.2 branch.

Discussion
----------

Use CPP where possible

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Some places cannot be changed as they rely on "PHP magic" things

Commits
-------

877f6b2951 Use CPP where possible
* 7.1:
  Fix ProcessTest - testIgnoringSignal for local
  [Console][PhpUnitBridge][VarDumper] Fix `NO_COLOR` empty value handling
  [Translation] Fix CSV escape char in `CsvFileLoader` on PHP >= 7.4
  [DoctrineBridge] fix messenger bus dispatch inside an active transaction
  [HttpFoundation] Add tests for uncovered sections
  treat uninitialized properties referenced by property paths as null
  [PropertyInfo] Check if property is nullable when using `ReflectionExtractor`
  properly set up constraint options
  [ErrorHandler][VarDumper] Remove PHP 8.4 deprecations
  move adding detailed JSON error messages to the validate phase
  [Profiler] Add word wrap in tables in dialog to see all the text
  [Core] Fix & Enhance security arabic translation.
  [HttpFoundation] Add tests for `MethodRequestMatcher` and `SchemeRequestMatcher`
…`` (parentheses for anonymous classes) (bonroyage)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

I have created a PR (PHP-CS-Fixer/PHP-CS-Fixer#8140) in the PHP-CS-Fixer repo to bring the ``@PER`-CS2.0` ruleset in line with the specifications on the `new_with_parentheses` rule for anonymous classes. Since the ``@Symfony`` ruleset builds upon the ``@PER`-CS2.0` ruleset, they would like confirmation that the Symfony community is OK with this change affecting the Symfony ruleset as well. Should it not be, I'll push another commit there ensuring that the change does not affect ``@Symfony``.

Therefore, this PR is not meant to be merged, but function as an RFC to get your opinion and show the effect it would have when applied to the Symfony source.

Commits
-------

506e0dd327 Code style change in ``@PER`-CS2.0` affecting ``@Symfony`` (parentheses for anonymous classes)
* 7.1: (31 commits)
  [Serializer] Remove useless calls to `func_get_arg()`
  fix tests using Twig 3.12
  skip tests requiring the intl extension if it's not installed
  🐛 throw ParseException on invalid date
  [FrameworkBundle] Re-remove redundant name attribute from `default_context`
  fix permitted data type of the default choice
  [ExpressionLanguage] Improve test coverage
  Fix invalid phpdoc in ContainerBuilder
  [HttpKernel] [WebProfileBundle] Fix Routing panel for URLs with a colon
  [Form] NumberType: Fix parsing of numbers in exponential notation with negative exponent
  Fix importing PHP config in prepend extension method
  [Messenger] Prevent waiting time to overflow when using long delays
  [Security] consistent singular/plural translation in Dutch
  reset the validation context after validating nested constraints
  do not duplicate directory separators
  fix handling empty data in ValueToDuplicatesTransformer
  fix compatibility with redis extension 6.0.3+
  synchronize unsupported scheme tests
  [String] Fixed Quorum plural, that was inflected to be only "Quora" and never "Quorums"
  Fix symfony/kaz-info-teh-notifier package
  ...
…variable (artshade)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

[VarDumper] Add support for `FORCE_COLOR` environment variable

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

5b545240c6 [PhpUnitBridge][Console][VarDumper] Add support for `FORCE_COLOR` environment variable
* 7.1:
  Replace external FTP server by a local docker instance
  [PhpUnitBridge][Console][VarDumper] Fix handling NO_COLOR env var
  fix test
  [Validator] Add test for `D` regex modifier in `TimeValidator`
* 7.1:
  [Serializer] Remove redundant @internal tags from traceable classes
  Fix conversion of partitioned cookies in the PSR-7 bridge
  [Validator] added Polish translation for units 116-119
  Revert stateless check
  [Console] Fix side-effects from running bash completions
  skip transient Redis integration tests on AppVeyor
* 7.1:
  Mitigate PHPUnit deprecations
  [TwigBundle] Add support for resetting globals between HTTP requests
  [Process] Fix backwards compatibility for invalid commands
  Mitigate PHPUnit deprecations
  [Cache] Fix compatibility with Redis 6.1.0 pre-releases
  [Validator] Add Catalan and Spanish translation for `Week` constraint
  Don't use is_resource() on non-streams
  [Ldap] Fix extension deprecation
* 7.1:
  Fix named arguments in data providers
  Make more data providers static
  fix merge
  Mutate remaining data providers to static ones
nicolas-grekas and others added 24 commits September 25, 2024 16:09
* 7.1:
  Tweak error/exception handler registration
* 7.1:
  Add PR template and auto-close PR on subtree split repositories
…aubois)

This PR was merged into the 7.2 branch.

Discussion
----------

Remove useless parent method calls in tests

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

The vast majority of tests don't call these parent methods, because they are no op. There are a few places where they are called, let's remove them?

Commits
-------

b54596f604 Remove useless parent method calls in tests
* 7.1:
  [TwigBridge] Remove `VersionAwareTest` from `AbstractLayoutTestCase`
  [DependencyInjection] Add coverage for error cases of `LazyClosure` and `AutowireLocator`
  [TwigBridge] Fixed a parameterized choice label translation
  Fix extracting of message from ->trans() method with named params
  [TwigBridge] Remove usage of Node() instantiations
  Update security.bg.xlf
  [Dotenv] Default value can be empty
  [Emoji] Update data to support emoji 16
  Add missing Albanian translations for Security and Validator components
  [HttpClient] Add `crypto_method` to scoped client options
  suppress proc_open errors
  [DependencyInjection] Fix `XmlFileLoader` not respecting when env for services
This PR was merged into the 7.2 branch.

Discussion
----------

Various CS fix for consistency

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

A few fixes to match the rest of the codebase:

- Remove useless `else` branches (as done in symfony/symfony#57897)
- Instantiating anonymous classes should not be followed by parentheses
- An attribute without args should not be followed by parentheses

Commits
-------

75582694ec Various CS fix for consistency
…` (LauLaman)

This PR was merged into the 7.2 branch.

Discussion
----------

[Console] Add finished indicator to `ProgressIndicator`

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Issues        |  <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT

Add a (configurable) finished indicator to the progress indicator to show that the progress is finished instead of last used indicator value.
This will make the output a bit nicer

instead of
```
 - Process A (4 secs, 8.0 MiB)
 \ Process B (1 min, 39 secs, 18.0 MiB)
 - Process C (7 secs, 18.0 MiB)
 - Process D (48 secs, 20.0 MiB)
 / Process E (45 secs, 20.0 MiB)

```

The output will look now like this:
```
 ✔ Process A (4 secs, 8.0 MiB)
 ✔ Process B (1 min, 39 secs, 18.0 MiB)
 ✔ Process C (7 secs, 18.0 MiB)
 ✔ Process D (48 secs, 20.0 MiB)
 ✔ Process E (45 secs, 20.0 MiB)
```

Commits
-------

b13fffc82e Add finished indicator to ProgressIndicator
* 7.1:
  fix detecting anonymous exception classes on Windows and PHP 7
  skip tests requiring the intl extension if it's not installed
  [RateLimiter] Fix DateInterval normalization
  re-add missing profiler shortcuts on profiler homepage
  Fix support for \SplTempFileObject in BinaryFileResponse
  [Security] Store original token in token storage when implicitly exiting impersonation
  [Cache] Fix clear() when using Predis
* 7.1:
  Port Appveyor to GitHub Actions
  normalize paths to avoid failures if a path is referenced by different names
  skip autocomplete test when stty is not available
  Bump Symfony version to 7.1.8
  Update VERSION for 7.1.7
  Update CHANGELOG for 7.1.7
  Bump Symfony version to 6.4.15
  Update VERSION for 6.4.14
  Update CHANGELOG for 6.4.14
  Bump Symfony version to 5.4.47
  Update VERSION for 5.4.46
  Update CONTRIBUTORS for 5.4.46
  Update CHANGELOG for 5.4.46
* 7.1:
  [Console] Fix division by 0 error
  [ErrorHandler] Fix error message with PHP 8.5
  add test covering associated entities referenced by their primary key
  Add an experimental CI job for PHP 8.5
  Fix change log to mentioned thrown exception
  [HttpClient] Always set CURLOPT_CUSTOMREQUEST to the correct HTTP method in CurlHttpClient
  evaluate access flags for properties with asymmetric visibility
  [Mime] Fix wrong PHPDoc in `FormDataPart` constructor
* 6.4:
  fix risky test that doesn't perform any assertions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.