-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add wickedone/phrase-tag-bundle #1733
add wickedone/phrase-tag-bundle #1733
Conversation
wickedOne
commented
Dec 20, 2024
Q | A |
---|---|
License | MIT |
Packagist | wickedone/phrase-tag-bundle |
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
Head branch was pushed to by a user without write access
6f4f90a
to
98778a9
Compare
Head branch was pushed to by a user without write access
98778a9
to
58862fd
Compare
Can you remove unrelated changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove unrelated changes as Fabian mentioned.
"copy-from-recipe": { | ||
"config/": "%CONFIG_DIR%/" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add wickedone/phrase-tag-bundle recipe
Head branch was pushed to by a user without write access
58862fd
to
93bfd59
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed it at first, file name should follow bundle name,
--- wickedone.yaml
+++ wicked_one_phrase_tag.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Head branch was pushed to by a user without write access