Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wickedone/phrase-tag-bundle #1733

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

wickedOne
Copy link
Contributor

Q A
License MIT
Packagist wickedone/phrase-tag-bundle

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 20, 2024 09:48
Copy link

github-actions bot commented Dec 20, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1733/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1733/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'wickedone/phrase-tag-bundle:^2.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled December 20, 2024 09:49

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 20, 2024 09:49
auto-merge was automatically disabled December 20, 2024 09:53

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 20, 2024 09:53
@fabpot
Copy link
Member

fabpot commented Dec 23, 2024

Can you remove unrelated changes?

Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unrelated changes as Fabian mentioned.

Comment on lines 5 to 10
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, you can offer to configure DSN as well.
image

Suggested change
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
}
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
},
"env": {
"PHRASE_DSN": "phrase://PROJECT_ID:API_TOKEN@default?userAgent=myProject"
}

- add wickedone/phrase-tag-bundle recipe
auto-merge was automatically disabled December 24, 2024 11:56

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 24, 2024 11:57
@wickedOne
Copy link
Contributor Author

  • removed unrelated changes (sorry, no idea how they managed to get in there)
  • implemented PHRASE_DSN env var as suggested by @diimpp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed it at first, file name should follow bundle name,

--- wickedone.yaml
+++ wicked_one_phrase_tag.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

auto-merge was automatically disabled December 24, 2024 17:32

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 24, 2024 17:32
@symfony-recipes-bot symfony-recipes-bot merged commit 96e66e2 into symfony:main Dec 24, 2024
1 of 2 checks passed
@wickedOne wickedOne deleted the phrase-tag-bundle branch December 25, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants