Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use yaml instead of php for config #1736

Merged
merged 5 commits into from
Jan 4, 2025
Merged

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Jan 3, 2025

Q A
License MIT
Packagist https://packagist.org/packages/survos/crawler-bundle

Use yaml instead of PHP for bundle configuration

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) January 3, 2025 22:52
Copy link

github-actions bot commented Jan 3, 2025

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1736/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1736/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'survos/crawler-bundle:^1.5'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled January 3, 2025 23:17

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) January 3, 2025 23:18
auto-merge was automatically disabled January 4, 2025 00:19

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) January 4, 2025 00:20
auto-merge was automatically disabled January 4, 2025 00:25

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) January 4, 2025 00:26
@tacman
Copy link
Contributor Author

tacman commented Jan 4, 2025

My bundle doesn't support php7. So why is it complaining?

@symfony-recipes-bot symfony-recipes-bot merged commit 26c9095 into symfony:main Jan 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants