Mark the misd/phone-number-bundle abandoned #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
maxhelias
approved these changes
Nov 28, 2019
jderusse
commented
Nov 28, 2019
| dbal: | ||
| types: | ||
| phone_number: Misd\PhoneNumberBundle\Doctrine\DBAL\Types\PhoneNumberType | ||
| # doctrine: |
There was a problem hiding this comment.
not related to that PR, but doctrine is not a required dependency
|
This a feature of packagist. It shouldn't be in a recipe IMHO. |
|
@Nyholm sadly, the project is dead, the maintainers does not respond to issues or pings (misd-service-development/phone-number-bundle#200 (comment)). |
mbabker
reviewed
Dec 2, 2019
|
Thank you @Nyholm, not an easy decision. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following misd-service-development/phone-number-bundle#217
This PR adds a warning in the post_install script of
misd/phone-number-bundlethat indicate the packageabandoned