Add manual fan control #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crawfxrd
added a commit
to system76/coreboot
that referenced
this pull request
Dec 31, 2024
system76/ec#512 added a manual fan control option. In manual control mode, the system firmware or OS is responsible for setting the fan target duty percent to manage thermals. Percent is used rather than raw PWM value (as is returned in GFAN) as the EC may be configured in such a way that the valid range is not 0-255. Change-Id: Iba8cd5ac540f9fdc20473831787cafb6c1fd8129 Signed-off-by: Tim Crawford <[email protected]>
crawfxrd
added a commit
to system76/coreboot
that referenced
this pull request
Dec 31, 2024
system76/ec#512 added a manual fan control option. In manual control mode, the system firmware or OS is responsible for setting the fan target duty percent to manage thermals. Percent is used rather than raw PWM value (as is returned in GFAN) as the EC may be configured in such a way that the valid range is not 0-255. RPM target is not supported. Change-Id: Iba8cd5ac540f9fdc20473831787cafb6c1fd8129 Signed-off-by: Tim Crawford <[email protected]>
crawfxrd
force-pushed
the
fan-manual
branch
2 times, most recently
from
4092704 to
420cd94
Compare
crawfxrd
added a commit
to system76/coreboot
that referenced
this pull request
Jan 2, 2025
system76/ec#512 added a manual fan control option. In manual control mode, the system firmware or OS is responsible for setting the fan target duty to manage thermals. CTR0 in the EC code determines the maximum valid PWM duty, which is hard-coded to 255. RPM target is not supported. Change-Id: Iba8cd5ac540f9fdc20473831787cafb6c1fd8129 Signed-off-by: Tim Crawford <[email protected]>
crawfxrd
added a commit
to system76/coreboot
that referenced
this pull request
Jan 2, 2025
system76/ec#512 added a manual fan control option. In manual control mode, the system firmware or OS is responsible for setting the fan target duty to manage thermals. CTR0 in the EC code determines the maximum valid PWM duty, which is hard-coded to 255. RPM target is not supported. Change-Id: Iba8cd5ac540f9fdc20473831787cafb6c1fd8129 Signed-off-by: Tim Crawford <[email protected]>
crawfxrd
added a commit
to system76/coreboot
that referenced
this pull request
Jan 2, 2025
system76/ec#512 added a manual fan control option. In PWM control mode, the system firmware or OS is responsible for setting the fan target duty to manage thermals. CTR0 in the EC code determines the maximum valid PWM duty, which is hard-coded to 255. RPM target is not supported. Change-Id: Iba8cd5ac540f9fdc20473831787cafb6c1fd8129 Signed-off-by: Tim Crawford <[email protected]>
Make the command and function names explicit that they are for controlling fan PWM duty. Signed-off-by: Tim Crawford <[email protected]>
Allow fan target duties to be set via ACPI or SMFI command. This will allow system firmware or OS to set fan duty, which can be used for testing or implementing user-defined fan tables. Setting PWM via SMFI already existed, but would not work as the value would simply be overwritten by the EC. RPM target is not supported. Signed-off-by: Tim Crawford <[email protected]>
leviport
approved these changes
Jan 15, 2025
jackpot51
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow fan target duties to be set via ACPI or SMFI command. This will allow system firmware or OS to set fan duty, which can be used for testing or implementing user-defined fan tables.
Setting PWM via SMFI already existed, but would not work as the value would simply be overwritten by the EC.
RPM target is not supported.
Ref: system76/coreboot#245
Ref: system76/firmware-open#570
Ref: system76/firmware-open#571