-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch 3 #35
Conversation
This is merging into the wrong branch. |
Is this ready for reviews? I have a launch_3.1 PCB in a Heavy, and I've been using it for a few days without any issues. |
I am ready if you are ready @leviport |
Oh one more thing; should this be tested with supporting keyboard-configurator changes, or can that be handled after getting this firmware tested and merged? |
Looks like "UNLOCKED" mode isn't working on this version. It seems to put it into bootloader mode instead, but I'm not sure it's flashing quite right when flashing with the make commands in this bootloader mode. Seems like I need to flash it twice for it to actually change the keymap to the one I specify in the make command. Plugging in while holding Esc flashes the correct keymap and seems to reset the keyboard, but keypresses don't work until I unplug and re-plug after flashing. |
|
The LED mapping correction is looking good, but I'm still seeing the weirdness I mentioned above with "UNLOCKED" mode. While testing pop-os/keyboard-configurator#181, I discovered that it could change LEDs on launch_{heavy_}3, but my changes are lost when I unplug/replug the keyboard. I'm not sure if that's an issue with that PR or with this firmware, so I also wanted to mention it here: pop-os/keyboard-configurator#181 (comment) |
One thing I see is that I don't think anything in the Configurator should cause that, if it works normally with other keyboards. I don't know how the EEPROM on this controller compares. |
The launch_heavy_3 I've been using for several days seems to have just keeled over. I've tested it on multiple computers with multiple USB cables, and it doesn't show any signs of life or show up in |
If you can give this a try again, that would help. The updated QMK from the thelio-io branch may improve things. Also, please try the other launch boards. |
I think merging this PR would solve #45 |
UNLOCKED mode no longer puts the controller into bootloader mode, and it no longer takes more than one flash to see the keymap change. The last remaining oddity I'm seeing is that after flashing with I'll begin regression testing on other Launch models now. |
Received a 3.2 prototype. So far the only problem I'm seeing is that LED settings that I set in the Configurator are dumped and reset to the default LED mode every time the keyboard is unplugged and plugged back in. Changes to the keymap itself seem to stick around just fine though. It does still take an extra unplug/re-plug after flashing with the |
Thank you for your contribution! |
Thank you for your contribution! |
Adds launch_3 board which is using the RP2040 controller