-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(raiko-lib): auto logging #219
Conversation
you have to fix your PR title first, something like "chore(project_name): verb ..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some good changes!
But feels like info
now prints very little, and debug
prints so much stuff it's hard to find anything back, so I think we need to tweak things some more so that the default log level still prints out a sufficient amount of useful information. Also seems like
raiko/lib/src/builder/execute.rs
Line 286 in a1ee3ae
debug!(" Ok: {result:?}"); |
trace
level now if we want to use the debug
level more because that one is very spammy and normally not useful.
I think it's okay to print some stuff using println
for stuff that is mostly just important while you're waiting on the block, like the transaction progress or the data fetching progress. That stuff is not so important for the logs, but very useful while you're staring at it and wondering how long something will still take to finish.
Currently the block execution though is very messy because of the optimistic execution still printing a lot of stuff, I think to solve that we could not print/log anything when is_optimistic
is true in execute_transactions
. Or something like that. We could also have a custom logger trait that people could set but that seems overkill.
Good stuff here @35359595. Some of the |
c028930
to
f13e527
Compare
f13e527
to
e24d7fc
Compare
RUST_LOG
env not present is set toinfo
level;println
logs replaced withtracing::debug
;debug
on most chatty outputs;