feat: impl reqactor #448
Open
feat: impl reqactor #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keroro520
force-pushed
the
feat/reqactor
branch
from
7fb4052 to
13d45cf
Compare
keroro520
force-pushed
the
feat/reqactor
branch
from
13d45cf to
17883a2
Compare
smtmfft
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
LGTM!
1 thing to clarify that you actually limit the concurreny by that 1024 channel? in burst there will be a problem cause networking I/O stuck, as potentially there are 1024 tasks asking for huge data transfer. That's why we used to have a self-impled software pending list, you can take this into consideration when you do next step.
| request_key: RequestKey, | ||
| old_status: StatusWithContext, | ||
| ) -> Result<StatusWithContext, String> { | ||
| debug_assert!( |
There was a problem hiding this comment.
it still has some chance that we cancel a complete statue task.
so maybe a if-trace better than debug_asset.
| // Ensure signal the request key to the internal channel. | ||
| // | ||
| // Note that this function will retry sending the signal until success. | ||
| async fn ensure_internal_signal(&mut self, request_key: RequestKey) { |
There was a problem hiding this comment.
should this ensure_signal has expected status/response?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.