add PRDC #431
Merged
add PRDC #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takuseno
requested changes
Nov 7, 2024
|
|
||
| import numpy as np | ||
| import torch | ||
| from scipy.spatial import KDTree |
There was a problem hiding this comment.
I think this is not used anywhere.
setup.py
Outdated
| @@ -43,6 +43,7 @@ | |||
| "colorama", | |||
| "dataclasses-json", | |||
| "gymnasium>=1.0.0", | |||
| "scipy", | |||
There was a problem hiding this comment.
I believe what you need here is scikit-learn instead of scipy.
There was a problem hiding this comment.
Thanks to your careful review. I have made the corresponding changes.
There was a problem hiding this comment.
btw, I've also fix errors from running ./scripts/lint.
takuseno
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Implementation of PRDC, arXiv link: https://arxiv.org/abs/2306.06569