Skip to content

Commit

Permalink
feat: using public docker image
Browse files Browse the repository at this point in the history
  • Loading branch information
tanhongit committed Jan 7, 2024
1 parent d5cebcf commit 8f2d682
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 10 deletions.
2 changes: 0 additions & 2 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ SMTP_UNAME
SMTP_PWORD

################### For docker ###################
PHP_VERSION_SELECTED=8.2

APP_NAME

APP_PORT
Expand Down
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,9 @@ Please edit the following information in the **.env** file:

(Please set ports for **MYSQL_PORT, PHPMYADMIN_PORT, APP_PORT, SSL_PORT** and not duplicate with other ports)

Example:
**Example:**

```dotenv
PHP_VERSION_SELECTED=8.2
APP_NAME=new-mvc-shop
APP_PORT=85
Expand Down
11 changes: 6 additions & 5 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ networks:

services:
server:
build:
context: .
dockerfile: ./docker/Dockerfile
args:
- PHP_VERSION_SELECTED=${PHP_VERSION_SELECTED:-8.2}
# build:
# context: .
# dockerfile: ./docker/Dockerfile
# args:
# - PHP_VERSION_SELECTED=${PHP_VERSION_SELECTED:-8.2}
image: tanhong/new-mvc-shop:docker
container_name: '${APP_NAME:-new_mvc_shop}-server'
ports:
- '${APP_PORT:-85}:80'
Expand Down

0 comments on commit 8f2d682

Please sign in to comment.