Skip to content

Commit

Permalink
fix(ci): remove build step when publishing typescript-bindings (#1096)
Browse files Browse the repository at this point in the history
Description
---
Removed the `npm build` step on `typescript-bindings` npm publish CI job

Motivation and Context
---
On #1093 we introduced a
step to build the npm package for both `wallet_jrpc_client` and
`typescript-bindings`.

We shouldn't include that step for `typescript-bindings` as we can
assume it's already built (there are checks for that) and the build runs
a custom script that builds all of the rust project using cargo.

So this PR removes the `npm build` step on `typescript-bindings` npm
publish CI job. We only need it for `wallet_jrpc_client`

How Has This Been Tested?
---
Does not apply

What process can a PR reviewer use to test or verify this change?
---
Does not apply

Breaking Changes
---

- [x] None
- [ ] Requires data directory to be deleted
- [ ] Other - Please specify
  • Loading branch information
mrnaveira authored Jul 26, 2024
1 parent 1c35d75 commit 1700fa0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/npm_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
with:
node-version: "20"
- run: npm ci
- run: npm run build
- uses: JS-DevTools/npm-publish@v3
with:
token: ${{ secrets.NPM_TOKEN }}
Expand Down

0 comments on commit 1700fa0

Please sign in to comment.