feat: add TryFrom impls for SubstateId and Addresses #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
approved these changes
Jan 15, 2025
sdbondi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Associated error type for
impl TryFrom<SubstateId> for Awas changed fromSubstateIdto an error type which wraps id. Implementations for main variants were provided.Motivation and Context
For users of Tari SDK it's important to convert SubstateId into one of subvariants (for example into ComponentAddress). Unfortunately
as_Tmethods return not an error type, butOption, which makes it verbose to manually wrap into own error types for handling. Existing implementation for ComponentAddress has associated type for error which doesn't implement error trait from Rust standard library. To improve developers experience new error type with some out of the box implementations proposed in this PR.How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
This change should not affect anything, so additional testing may not be needed.
Breaking Changes