fix(consensus)!: optmise foreign pledging for output-only case #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
consensus-output-only-optimise
branch
from
3df5147 to
739661e
Compare
Test Results (CI)607 tests ±0 607 ✅ ±0 3h 31m 11s ⏱️ - 9m 57s Results for commit fb912ec. ± Comparison against base commit 9500de9. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
sdbondi
force-pushed
the
consensus-output-only-optimise
branch
from
739661e to
c973a96
Compare
sdbondi
force-pushed
the
consensus-output-only-optimise
branch
from
c973a96 to
6a44427
Compare
sdbondi
force-pushed
the
consensus-output-only-optimise
branch
from
da8a7a2 to
238c0e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(consensus): output-only shard groups skip the LocalPrepare and AllPrepare phase and go straight to LocalAccept
fix(consensus)!: do not send substate values twice to the same shard groups for prepare and accept phases
fix(consensus)!: output pledges are never included in block pledges, taken directly from block evidence
fix(consensus): process foreign proposals in on_propose
fix(consensus): do not exclude substate pledges that are still pledged to other applicable transactions (Read lock case)
fix(consensus): bug causing incorrect failed validation of input pledges
fix(consensus): foreign abort reason is carried over to other shards (instead of the unhelpful "ForeignShardDecidedToAbort")
fix(consensus):
feat(vn/webui): add atom evidence JSON to block view
fix(swarm/webui): bug causing UI crash in abort case
Motivation and Context
General stability fixes and optimisations for consensus
How Has This Been Tested?
New consensus unit test
Manually tariswap bench, no observed problems
Breaking Changes
BREAKING CHANGE: changes to wire protocol