-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template-sync-test): updated tests to use new template syncing method #1247
Open
ksrichard
wants to merge
13
commits into
tari-project:development
Choose a base branch
from
ksrichard:feature/template-sync-tests
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(template-sync-test): updated tests to use new template syncing method #1247
ksrichard
wants to merge
13
commits into
tari-project:development
from
ksrichard:feature/template-sync-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… down substate as deletion
…emplates-when-syncing-substates
ksrichard
changed the title
Feature/template sync tests
feat(template-sync-test): updated tests to use new template syncing method
Jan 17, 2025
Test Results (CI)607 tests ±0 607 ✅ ±0 3h 48m 37s ⏱️ + 7m 29s Results for commit ffe2920. ± Comparison against base commit 9500de9. This pull request removes 10 and adds 10 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated tests to use the new template publishing method and possibly fixed the random cucumber test hanging without even exiting.
Important: #1242 must be merged to development before this PR could be
Motivation and Context
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes