Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[console wallet] Custom Base Node - clear #5353

Closed
leet4tari opened this issue Apr 26, 2023 · 1 comment · Fixed by #6746
Closed

[console wallet] Custom Base Node - clear #5353

leet4tari opened this issue Apr 26, 2023 · 1 comment · Fixed by #6746
Assignees
@hansieodendaal
Labels
A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue.

Comments

@leet4tari
Copy link
Contributor

Describe the bug
Adding multiple Custom Base Nodes, increases the base node list, but you can only clear/delete one entry (the last base node).

To Reproduce
Run the tari_console_wallet, navigate to the network tab.
Press P to add a base node. Enter base node pub key and address.
Add a second base node. Clear base node by pressing C.
Pressing C again does not remove the first base node added.

Expected behavior
Expected to be able to delete all Custom Base Nodes, not just last and no others.

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot 2023-04-26 at 09 54 04
Screenshot 2023-04-26 at 09 54 21

Desktop (please complete the following information):

  • Raspberry Pi 4 - Debian BullsEye
  • Tari Suite - v0.50.0-pre.0
@SWvheerden SWvheerden added A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue. labels May 2, 2023
@SWvheerden SWvheerden moved this to Should Do in Tari Esme Testnet May 9, 2023
@hansieodendaal hansieodendaal self-assigned this Jan 17, 2025
@hansieodendaal hansieodendaal mentioned this issue Jan 17, 2025
Merged
4 tasks
@hansieodendaal
Copy link
Contributor

See #6746

SWvheerden added a commit that referenced this issue Jan 17, 2025
@hansieodendaal @SWvheerden
feat: clear out custom base node (#6746)
9b35465 
Description
---
Cleared out the old custom base node in the console wallet base node
list in the network tab if another one is assigned.

**Note:** Currently in the console wallet we only accept one custom base
node, not a list. The new custom base node was added correctly and the
old one removed from the database, the only issue here was that the
Network tab display was not updated.

Fixes #5353

Motivation and Context
---
The old custom base node was not cleared from the list.

How Has This Been Tested?
---
System-level testing

What process can a PR reviewer use to test or verify this change?
---
Code review

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->

Co-authored-by: SW van Heerden <[email protected]>
@github-project-automation github-project-automation bot moved this from Should Do to Done in Tari Esme Testnet Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansieodendaal hansieodendaal

Labels
A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue.
Projects
Tari Esme Testnet
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: clear out custom base node hansieodendaal/tari
3 participants
@SWvheerden @hansieodendaal @leet4tari