Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clear out custom base node #6746

Merged

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Jan 17, 2025

Description

Cleared out the old custom base node in the console wallet base node list in the network tab if another one is assigned.

Note: Currently in the console wallet we only accept one custom base node, not a list. The new custom base node was added correctly and the old one removed from the database, the only issue here was that the Network tab display was not updated.

Fixes #5353

Motivation and Context

The old custom base node was not cleared from the list.

How Has This Been Tested?

System-level testing

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Cleared out the old custom base node in the console wallet base node list in the network
tab if another one is assigned.
Copy link

Test Results (CI)

    3 files    129 suites   37m 16s ⏱️
1 350 tests 1 350 ✅ 0 💤 0 ❌
4 048 runs  4 048 ✅ 0 💤 0 ❌

Results for commit 78b2adb.

Copy link

Test Results (Integration tests)

 2 files  11 suites   34m 0s ⏱️
36 tests 34 ✅ 0 💤 2 ❌
38 runs  36 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 78b2adb.

@SWvheerden SWvheerden merged commit 9b35465 into tari-project:development Jan 17, 2025
15 checks passed
@hansieodendaal hansieodendaal deleted the ho_custom_base_node branch January 17, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[console wallet] Custom Base Node - clear
2 participants