-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sort completed transactions #6733
chore: sort completed transactions #6733
Conversation
Test Results (CI)1 349 tests 1 348 ✅ 12m 7s ⏱️ For more details on these failures, see this check. Results for commit bec825e. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not do an order here in rust.
I would change it where it gets it from the database and use SQL to to do the order.
Also don't order by timestamp, order by mined_timestamp
…ri into mp_sort_completed_transactions
…ri into mp_sort_completed_transactions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Description
This pull request focuses on refactoring the transaction handling in the wallet service by replacing
HashMap
withVec
for storing transactions. This change impacts several parts of the codebase, including transaction service responses, database storage, and transaction handling logic. Additionaly, we sort txs bymined_timestamp
in desc order.Testing
Tested manually using
minotari_console_wallet