feat: new grpc method #6742
Merged
feat: new grpc method #6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 129 suites 37m 15s ⏱️ Results for commit 9b5f3eb. ♻️ This comment has been updated with latest results. |
hansieodendaal
previously approved these changes
Jan 16, 2025
brianp
previously approved these changes
Jan 16, 2025
Comment on lines
68
to
69
| if res.1 == *current_tip { | ||
| Some(res.0.clone()) |
There was a problem hiding this comment.
This is just a nit and not a change request.
I always prefer a struct and names values over indexing from a tuple res.1 or res.0 as they lose context and meaning in these functions.
There was a problem hiding this comment.
valid point, let me update
SWvheerden
dismissed stale reviews from brianp and hansieodendaal
via
9b5f3eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a new grpc method to get the reward of the nextblock, the sha + rx estimate hash rates and metadata tip info
Adds caching to grpc calls
Motivation and Context
Currently, universe calls get_template to just read the reward which is an expensive operation.
It also streams up to 100 headers to calculate the estimated hash rate.
Both of these operations can be made much simpler and faster. This PR provides a call to do just that.
This Pr also adds cahcing to the calls to only update if an update is required.