Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change Monero encoding trait name #75

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

SWvheerden
Copy link
Contributor

Changes the Monero base58 encoding name to reflect this is not standard base58 encoding and rather Monero-specific Base58 encoding. See: https://docs.getmonero.org/cryptography/base58/

Deprecates old name.

Release new version 0.8

stringhandler
stringhandler previously approved these changes Oct 10, 2024
release new version
stringhandler
stringhandler previously approved these changes Oct 10, 2024
CHANGELOG.md Outdated

### ⚠ BREAKING CHANGES

* Changes the `ByteArray` trait.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a better comment

@SWvheerden SWvheerden added this pull request to the merge queue Oct 10, 2024
Merged via the queue into tari-project:main with commit cbc2a76 Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants