chore: [DNM] tauri v2 upgrade #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanimal08
requested review from
brianp,
stringhandler,
Misieq01 and
leet4tari
shanimal08
force-pushed
the
build-chore-upgrade-tauri-v2
branch
from
f23f3e3 to
d69c8df
Compare
|
Not building on my end |
did you |
|
My bad, sorry hahah |
- wip: update dir resolvers - wip: move Systray logic to FE - wip: updated beta build workflows - wip: emit miner metrics - ci: updated workflows - merge: reolve conflicts
shanimal08
force-pushed
the
build-chore-upgrade-tauri-v2
branch
from
83c2a0a to
4c71ee8
Compare
shanimal08
requested review from
Krakaw,
mmrrnn,
PanchoBubble,
BalazsSevecsek and
ns212
MCozhusheck
reviewed
Dec 3, 2024
| &self, | ||
| config_dir: PathBuf, | ||
| ) -> Result<GpuStatusFileContent, Error> { | ||
| let file: PathBuf = config_dir.join("gpuminer").join("gpu_status.json"); |
There was a problem hiding this comment.
Hold on aren't cache_dir and config_dir different according to docs ?
|
|
||
| const UPDATE_CHECK_INTERVAL = 1000 * 60 * 60; // 1 hour | ||
|
|
||
| export const useHandleUpdate = () => { |
There was a problem hiding this comment.
Please verify that download progress works well. I had issue with tauri js API where it would get stuck from massive amounts of incoming Progress events. In the end rust API worked much better with high amount of events.
There was a problem hiding this comment.
we did check this with a draft auto update release a long while back and it seemed alright, i didn't get stuck :D but that hasn't been tested recently
brianp
reviewed
Dec 3, 2024
src-tauri/src/commands.rs
Outdated
| } | ||
| Err(e) => { | ||
| error!(target: LOG_TARGET, "Error loading internal wallet: {:?}", e); | ||
| Err(e) | ||
| Err::<(), std::string::String>(e.to_string()) |
There was a problem hiding this comment.
👀
did this not work?
Suggested change
| Err::<(), std::string::String>(e.to_string()) | |
| Err(e.to_string()) |
Description --- - set up `tauri-plugin-process` correctly for relaunch after install - adjusted the check for updates - adjusted the update handler Motivation and Context --- autoupdate didn't work properly in V2 branch How Has This Been Tested? --- locally. painstakingly.
## Fixes part of #1168 and potentialy fixes #1175 ### [ Content ] - Handle extra case for wallet creation when no data is present on machine - Fixed prolonged shutdowns sequences at the end of setup - Removed unnecessary thread spawn - Fixed `gpu_detection` and `gpu_status` generation ------------ ### [ Testing ] - Try copy or show seed words | play around with deleting wallet_config.json - For closing sequence => Close app around 85% or around time when we enter main app view
brianp
force-pushed
the
build-chore-upgrade-tauri-v2
branch
from
65dff44 to
f5a0827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
taurito V2 see their migration guide for more info:commands.rs) to decluttermain.rsMotivation and Context
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes