Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: timeout and log latest action during init #1183

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

MCozhusheck
Copy link
Collaborator

@MCozhusheck MCozhusheck commented Dec 4, 2024

Description

Timeout if initialization took too long and report to sentry the last action. Timeout is for each binary and is set to fixed value of 5 minutes.
Another big change is that app will exit and show error if timeout was exceeded. Previously user would be stuck at initialization screen.

Closes: #1170

Motivation and Context

Some users reports being stuck at initialization screen. The underlying reason is unknown and we need to increase the logging and sentry reporting.

How Has This Been Tested?

Decrease timeout to like 20 seconds and add this line in binaries_resolver.rs in initialize_binary function to fake timeout on one selected binary:

match binary {
    Binaries::Xmrig => {
        println!("Sleeping for 30 seconds");
        sleep(Duration::from_secs(30)).await;
        println!("Waking up");
    }
    _ => {}
}

What process can a PR reviewer use to test or verify this change?

Same as above

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@MCozhusheck MCozhusheck marked this pull request as ready for review December 5, 2024 11:45
@MCozhusheck MCozhusheck requested a review from brianp December 5, 2024 11:47
@brianp brianp merged commit d4b44af into tari-project:main Dec 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sentry & Logging at the 30% install mark
3 participants