fix(ui): intro animation optimization for main app sections #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peps
changed the title
shanimal08
approved these changes
Jan 16, 2025
|
love it! |
brianp
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Very clean on MacOS.
First run on windows was clean between Loading -> Setup, and Main -> Exiting
but it was a bit janky between Setup -> Main.
I tried it a couple times and it mostly worked well on recurring attempts. So I'm going to merge for now but keep an ear out for possible windows complaints.
|
@brianp thanks, ill look into ways to improve it on windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just cleaning up some of the intro animations so they flow more smoothly. This happens between the splash screen -> setup screen & setup screen -> dashboard.
CleanShot.2025-01-15.at.16.31.32-optimised.mp4
CleanShot.2025-01-15.at.16.34.52-optimised.mp4