Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: emit and logging cleanup #1390

Merged
merged 1 commit into from
Jan 16, 2025
Merged

refactor: emit and logging cleanup #1390

merged 1 commit into from
Jan 16, 2025

Conversation

shanimal08
Copy link
Collaborator

@shanimal08 shanimal08 commented Jan 16, 2025 •
edited
Loading

Description

  • removed a redundant log from auto launcher flow
  • updated the frontend_ready x app_ready emits:
    • separated them, moved FE emit to AppWrapper
    • changed the app_ready (FE) listener to use once
    • also changed the frontend_ready (BE) listener to use once

Motivation and Context + How Has This Been Tested?

locally

before:
before
after:
29555

What process can a PR reviewer use to test or verify this change?

  • run locally
  • compare terminal logs to when running latest main locally

@shanimal08 shanimal08 marked this pull request as ready for review January 16, 2025 07:39
@stringhandler stringhandler merged commit 4b25105 into tari-project:main Jan 16, 2025
13 of 14 checks passed
@shanimal08 shanimal08 deleted the chore/log_cleanup branch January 16, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmrrnn mmrrnn mmrrnn approved these changes

@brianp brianp Awaiting requested review from brianp

@Misieq01 Misieq01 Awaiting requested review from Misieq01

@stringhandler stringhandler Awaiting requested review from stringhandler

@MCozhusheck MCozhusheck Awaiting requested review from MCozhusheck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shanimal08 @mmrrnn @stringhandler