Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add root taurignore #10805

Merged
merged 2 commits into from
Aug 28, 2024
Merged

chore: add root taurignore #10805

merged 2 commits into from
Aug 28, 2024

Conversation

lucasfernog
Copy link
Member

enhances the DX of running tauri dev in any of the examples folder - we don't need to watch the entire workspace for changes

enhances the DX of running `tauri dev` in any of the examples folder - we don't need to watch the entire workspace for changes
@lucasfernog lucasfernog requested a review from a team as a code owner August 27, 2024 23:01
Copy link
Contributor

github-actions bot commented Aug 27, 2024

Package Changes Through 0a668a8

There are 8 changes which include tauri with prerelease, tauri-utils with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-codegen with prerelease, tauri-bundler with prerelease, @tauri-apps/api with prerelease, tauri-build with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.0.0-rc.3 2.0.0-rc.4
tauri-utils 2.0.0-rc.6 2.0.0-rc.7
tauri-bundler 2.0.1-rc.5 2.0.1-rc.6
tauri-runtime 2.0.0-rc.6 2.0.0-rc.7
tauri-runtime-wry 2.0.0-rc.6 2.0.0-rc.7
tauri-codegen 2.0.0-rc.6 2.0.0-rc.7
tauri-macros 2.0.0-rc.5 2.0.0-rc.6
tauri-plugin 2.0.0-rc.6 2.0.0-rc.7
tauri-build 2.0.0-rc.6 2.0.0-rc.7
tauri 2.0.0-rc.6 2.0.0-rc.7
@tauri-apps/cli 2.0.0-rc.7 2.0.0-rc.8
tauri-cli 2.0.0-rc.7 2.0.0-rc.8

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog
Copy link
Member Author

we could ignore the entire crates folder, idk about that
tbh i don't use tauri dev in the examples much, it's mostly mobile dev that impacts me

.taurignore Outdated
crates/tauri-schema-generator
crates/tests
bench
.changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we ignoring .changes, should we also ignore .github, .docker and other directories ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how often do we change these anyway? 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never but this is about local development and it could either be accidentally saved or you could be changing a workflow while working on a feature, I'd say add them just in case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool will do that tomorrow when i wake up

@lucasfernog lucasfernog requested a review from amrbashir August 28, 2024 13:36
@amrbashir amrbashir merged commit d1c97bc into dev Aug 28, 2024
8 checks passed
@amrbashir amrbashir deleted the chore/root-taurignore branch August 28, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants