Editorial: more explicit handling of [[PromiseResult]] #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Nov 21, 2024
syg
approved these changes
Jan 8, 2025
bakkot
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
[[PromiseResult]]of a Promise is only initialized when the Promise actually settles. Generally we prefer to initialize everything explicitly. See #3482 (which also covers[[GeneratorContext]]).There's various places which use this field without asserting that it's not
~empty~, which might confuse esmeta, but those places do assert that the state is not~pending~, so an additional assert seemed like overkill. I could add those asserts anyway if we want though.