Skip to content

Commit

Permalink
pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
guybedford committed May 16, 2024
1 parent a608f3b commit 33be897
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion build/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -3936,7 +3936,7 @@ <h1><span class="secnum">16.1.1.2.1</span> <ins>PopulateExportStarSet ( [ <var>e
<p>The PopulateExportStarSet concrete method of a <emu-xref href="#sourctextmodule-record"><a href="https://tc39.es/ecma262/#sourctextmodule-record">Source Text Module Record</a></emu-xref> <var>module</var> takes optional argument <var>exportStarSet</var> (a <emu-xref href="#sec-list-and-record-specification-type"><a href="https://tc39.es/ecma262/#sec-list-and-record-specification-type">List</a></emu-xref> of <del>Source Text</del><emu-xref href="#cyclic-module-record" id="_ref_34"><a href="#cyclic-module-record">Cyclic Module Records</a></emu-xref>) and returns a <emu-xref href="#sec-list-and-record-specification-type"><a href="https://tc39.es/ecma262/#sec-list-and-record-specification-type">List</a></emu-xref> of Strings. It performs the following steps when called:</p>
<emu-alg><ol><li><emu-xref href="#assert"><a href="https://tc39.es/ecma262/#assert">Assert</a></emu-xref>: <var>module</var>.<var class="field">[[Status]]</var> is not <emu-const>new</emu-const>.</li><li>If <var>exportStarSet</var> is not present, set <var>exportStarSet</var> to a new empty <emu-xref href="#sec-list-and-record-specification-type"><a href="https://tc39.es/ecma262/#sec-list-and-record-specification-type">List</a></emu-xref>.</li><li>If <var>exportStarSet</var> contains <var>module</var>, then<ol><li><emu-xref href="#assert"><a href="https://tc39.es/ecma262/#assert">Assert</a></emu-xref>: We've reached the starting point of an <code>export *</code> circularity.</li><li>Return a new empty <emu-xref href="#sec-list-and-record-specification-type"><a href="https://tc39.es/ecma262/#sec-list-and-record-specification-type">List</a></emu-xref>.</li></ol></li><li>Append <var>module</var> to <var>exportStarSet</var>.</li><li>Let <var>starExportRequests</var> be !&nbsp;<var>module</var>.GetStarExports().</li><li>For each ModuleRequest <var>request</var> of <var>starExportRequests</var>, do<ol><li>Let <var>requestedModule</var> be <emu-xref aoid="GetImportedModule"><a href="https://tc39.es/ecma262/#sec-GetImportedModule">GetImportedModule</a></emu-xref>(<var>module</var>, <var>request</var>).</li><li>Perform !&nbsp;<var>requestedModule</var>.PopulateExportStarSet(<var>exportStarSet</var>).</li></ol></li><li>Return <var>exportStarSet</var>.</li></ol></emu-alg>
<emu-note><span class="note">Note</span><div class="note-contents">
<p>GetExportedNames does not filter out or throw an exception for names that have ambiguous star export bindings.</p>
<p>PopulateExportStarSet does not filter out or throw an exception for names that have ambiguous star export bindings.</p>
</div></emu-note>
</emu-clause>
</emu-clause>
Expand Down
2 changes: 1 addition & 1 deletion spec.emu
Original file line number Diff line number Diff line change
Expand Up @@ -1294,7 +1294,7 @@ contributors: Luca Casonato, Guy Bedford
1. Return _exportStarSet_.
</emu-alg>
<emu-note>
<p>GetExportedNames does not filter out or throw an exception for names that have ambiguous star export bindings.</p>
<p>PopulateExportStarSet does not filter out or throw an exception for names that have ambiguous star export bindings.</p>
</emu-note>
</emu-clause>
</emu-clause>
Expand Down

0 comments on commit 33be897

Please sign in to comment.