Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify worker problem statement, rename to 'Source Text Phase Imports' #2

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

guybedford
Copy link
Collaborator

@guybedford guybedford commented Jan 24, 2024

As discussed in the previous meeting, this restructures the proposal to focus first and foremost on the worker problem statement exactly as it has been doing, but with a bunch of simplifications around presenting that and putting the statement first.

The background mentions how in our overall layering work this is seen as a good next step due to the importance of the worker design constraints.

I've kept the proposal layering section, with rewriting for applying to both source and instance.

All of the use cases touched on in the use cases section should be covered by the motivation now, but please let me know if there is anything else there we should keep - I entirely removed the capability section as I wasn't sure how to frame this into the worker problem statement, but I'm open to bringing it back in some form if necessary.

The renaming to 'Source Text Phase Imports' is to indicate that the exact phase definition is not yet fully clear for the Stage 1 proposal phase, to give us some design flexibility here.

@guybedford guybedford mentioned this pull request Jan 24, 2024
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

README.md Outdated
@@ -1,77 +1,35 @@
# Module Instance Imports
# Source Text Phase Imports
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Source Text Phase Imports
# JavaScript Phase X Imports

it really sounds as if "Source Text" is a new phase that we never mentioned before, while what we are actually doing is just not picking a phase yet. Maybe this makes it more clear?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sure I've changed the proposal name to ECMAScript Module Phase Imports here.

README.md Outdated Show resolved Hide resolved
@guybedford guybedford merged commit 7ca9bdf into tc39:main Jan 25, 2024
1 check passed
@guybedford guybedford deleted the some-phase branch January 25, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants