Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorial: editor review feedback #44

Merged
merged 6 commits into from
Dec 1, 2024
Merged

editorial: editor review feedback #44

merged 6 commits into from
Dec 1, 2024

Conversation

guybedford
Copy link
Collaborator

Implements the feedback from the review in #26 (comment), including:

  • Moving the realm validation in EvaluateImportCall to after the full options validation
  • Adding a readme note about the intrinsic reachability for AbstractModuleSource
  • Adding a note about ModuleSourcesEqual
  • Replacing @@toStringTag with %Symbol.toStringTag%.
  • Renaming GetModuleSourceName internal method to GetModuleSourceKind
  • Updated description grammar

@guybedford guybedford mentioned this pull request Nov 30, 2024
Open
6 tasks
bakkot
bakkot reviewed Dec 1, 2024
View reviewed changes
spec.emu Outdated Show resolved Hide resolved
guybedford and others added 2 commits December 1, 2024 12:12
@guybedford @bakkot
Update spec.emu
bee5fb1 
Co-authored-by: Kevin Gibbons <[email protected]>
@guybedford
rebuild
6327f93
@guybedford guybedford merged commit 5bbeeed into main Dec 1, 2024
1 check passed
@guybedford guybedford deleted the editor-feedback-3 branch December 1, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guybedford @bakkot