Merge pull request #1381 from mShan0/mshan0-issue1361

feat: deprecate default value for trustServerCertificate
tediousjs · Jan 12, 2022 · 212c68e · 212c68e
2 parents b2d0fa2 + ea7f990
commit 212c68e
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/src/connection.ts b/src/connection.ts
@@ -47,6 +47,15 @@ import { version } from '../package.json';
 import { URL } from 'url';
 import { AttentionTokenHandler, InitialSqlTokenHandler, Login7TokenHandler, RequestTokenHandler, TokenHandler } from './token/handler';
 
+let trustServerWarningEmitted = false;
+
+const emitTrustServerCertificateWarning = () => {
+  if (!trustServerWarningEmitted) {
+    trustServerWarningEmitted = true;
+    process.emitWarning('`config.options.trustServerCertificate` will default to false in the future. To silence this message, specify a value explicitly in the config options');
+  }
+};
+
 type BeginTransactionCallback =
   /**
    * The callback is called when the request to start the transaction has completed,
@@ -1604,6 +1613,8 @@ class Connection extends EventEmitter {
         }
 
         this.config.options.trustServerCertificate = config.options.trustServerCertificate;
+      } else {
+        emitTrustServerCertificateWarning();
       }
 
       if (config.options.useColumnNames !== undefined) {