Skip to content

Commit

Permalink
scenario: Fix antenna configuration keyword
Browse files Browse the repository at this point in the history
Co-authored-by: Daniele Pugliese <[email protected]>
  • Loading branch information
GiovanniGrieco and Daniele Pugliese committed May 31, 2024
1 parent afa11b2 commit 7e973e2
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions scenario/integrated_ntn.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down Expand Up @@ -153,7 +153,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down
4 changes: 2 additions & 2 deletions scenario/ntn-hap-big.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down Expand Up @@ -126,7 +126,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down
4 changes: 2 additions & 2 deletions scenario/ntn-hap-static.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down Expand Up @@ -122,7 +122,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down
4 changes: 2 additions & 2 deletions scenario/ntn-hap-sweep.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down Expand Up @@ -123,7 +123,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down
4 changes: 2 additions & 2 deletions scenario/ntn-hap-test.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down Expand Up @@ -126,7 +126,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down
4 changes: 2 additions & 2 deletions scenario/ntn-hap.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down Expand Up @@ -129,7 +129,7 @@
// TODO: What's the relation between netDevices and antennas?
// Antenna may be configured globally on the node. In this way, all the netDevices will use the same antenna.
// If we want to configure different antennas for different netDevices, we have to specify the antenna in the netDevice.
"antenna": {
"antennaModel": {
"name": "ns3::UniformPlanarArray",
"attributes": [
{
Expand Down
2 changes: 1 addition & 1 deletion src/configuration/helper/entity-configuration-helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ EntityConfigurationHelper::DecodeNetdeviceConfigurations(const rapidjson::Value&
}();

const auto antennaModel =
ModelConfigurationHelper::GetOptional(netdev.GetObject(), "antenna");
ModelConfigurationHelper::GetOptional(netdev.GetObject(), "antennaModel");

if (type == "wifi")
{
Expand Down

0 comments on commit 7e973e2

Please sign in to comment.