Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Adds basic scheduler #16
wip: Adds basic scheduler #16
Changes from all commits
f4b9653
542a3de
0f80c07
10a39b9
2925650
c0500d3
1403d73
8afb1a6
6d53a72
bdd4ee7
6c5e41a
0847885
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should pick a proper name for "something that's run in the background", especially if we plan to add advanced monitoring tools later (horizon-like).
Those are the names I can come up with. I like
Task
the most, but I'm not sure whether it's too ambiguous.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a better way to invoke the task. I'll play around with it once it's merged
Check failure on line 25 in src/Commands/SchedulerRunInvocationCommand.php
GitHub Actions / Perform Static Analysis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I want to rework the whole invocation structure. Instead of going through the shell again, we can build the command, and then pass it to the
ConsoleApplication
without having to boot tempest once more.This is something I'll refactor after merge though, as it might involve some bigger changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: maybe it won't be possible, because we want to run stuff in the background. Ok, I'll just play around with it and see where it leads me