-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create test-runner command for rerunning tests #6842
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cae070f
Create test-runner command for rerunning tests
bergundy c718bd1
Revert change to tests/callbacks_test.go
bergundy 3ba1f6b
Remove outdated comment
bergundy 04fca19
Format imports and add license
bergundy 237aca8
Address review comment
bergundy 5f32fd3
Add comment per CR
bergundy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "go.temporal.io/server/tools/testrunner" | ||
| ) | ||
|
|
||
| func main() { | ||
| testrunner.Main() | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <testsuites time="14.760843" tests="7" failures="2"> | ||
| <testsuite name="go.temporal.io/server/tests" tests="7" failures="2" errors="0" id="0" time="9.426000" timestamp="2024-11-18T14:05:44-08:00"> | ||
| <properties> | ||
| <property name="go.version" value="go1.23.2 darwin/arm64"></property> | ||
| </properties> | ||
| <testcase name="TestCallbacksSuite/TestWorkflowCallbacks_InvalidArgument" classname="go.temporal.io/server/tests" time="0.000000"> | ||
| <failure message="Failed"><![CDATA[=== RUN TestCallbacksSuite/TestWorkflowCallbacks_InvalidArgument | ||
| callbacks_test.go:99: | ||
| Error Trace: /Users/me/temporal/temporal/tests/callbacks_test.go:99 | ||
| Error: Not equal: | ||
| expected: 1 | ||
| actual : 2 | ||
| Test: TestCallbacksSuite/TestWorkflowCallbacks_InvalidArgument | ||
| --- FAIL: TestCallbacksSuite/TestWorkflowCallbacks_InvalidArgument (0.00s) | ||
| ]]></failure> | ||
| </testcase> | ||
| <testcase name="TestCallbacksSuite" classname="go.temporal.io/server/tests" time="8.330000"> | ||
| <failure message="Failed"><![CDATA[=== RUN TestCallbacksSuite | ||
| === PAUSE TestCallbacksSuite | ||
| === CONT TestCallbacksSuite | ||
| --- FAIL: TestCallbacksSuite (8.33s) | ||
| ]]></failure> | ||
| </testcase> | ||
| <testcase name="TestCallbacksSuite/TestNexusResetWorkflowWithCallback" classname="go.temporal.io/server/tests" time="0.020000"></testcase> | ||
| <testcase name="TestCallbacksSuite/TestWorkflowNexusCallbacks_CarriedOver/ContinueAsNew" classname="go.temporal.io/server/tests" time="2.029000"></testcase> | ||
| <testcase name="TestCallbacksSuite/TestWorkflowNexusCallbacks_CarriedOver/WorkflowRunTimeout" classname="go.temporal.io/server/tests" time="3.030000"></testcase> | ||
| <testcase name="TestCallbacksSuite/TestWorkflowNexusCallbacks_CarriedOver/WorkflowFailureRetry" classname="go.temporal.io/server/tests" time="2.040000"></testcase> | ||
| <testcase name="TestCallbacksSuite/TestWorkflowNexusCallbacks_CarriedOver" classname="go.temporal.io/server/tests" time="7.100000"></testcase> | ||
| </testsuite> | ||
| </testsuites> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <testsuites tests="2" failures="2" errors="0" time="2.244000"> | ||
| <testsuite name="go.temporal.io/server/tests" tests="2" failures="2" errors="0" id="0" time="2.244000" timestamp="2024-11-18T13:57:56-08:00"> | ||
| <properties> | ||
| <property name="go.version" value="go1.23.2 darwin/arm64"></property> | ||
| </properties> | ||
| <testcase name="TestCallbacksSuite/TestWorkflowCallbacks_InvalidArgument" classname="go.temporal.io/server/tests" time="0.000000"> | ||
| <failure message="Failed"><![CDATA[=== RUN TestCallbacksSuite/TestWorkflowCallbacks_InvalidArgument | ||
| callbacks_test.go:99: | ||
| Error Trace: /Users/me/temporal/temporal/tests/callbacks_test.go:99 | ||
| Error: Not equal: | ||
| expected: 1 | ||
| actual : 2 | ||
| Test: TestCallbacksSuite/TestWorkflowCallbacks_InvalidArgument | ||
| --- FAIL: TestCallbacksSuite/TestWorkflowCallbacks_InvalidArgument (0.00s) | ||
| ]]></failure> | ||
| </testcase> | ||
| <testcase name="TestCallbacksSuite" classname="go.temporal.io/server/tests" time="1.200000"> | ||
| <failure message="Failed"><![CDATA[=== RUN TestCallbacksSuite | ||
| === PAUSE TestCallbacksSuite | ||
| === CONT TestCallbacksSuite | ||
| --- FAIL: TestCallbacksSuite (1.20s) | ||
| ]]></failure> | ||
| </testcase> | ||
| </testsuite> | ||
| </testsuites> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a way to pre-build this in our CI setup. I can look into that if anyone thinks using
go runwould be an issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything you build in
pre-build-functional-test-coveragewill go into the per-run cache. That won't cover the final binary (I think) but the object files. I wouldn't worry about it, though, the compile+link time should be negligible.