This repository has been archived by the owner on May 11, 2021. It is now read-only.
update Go version from 1.9 to 1.12 #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go 1.12はApp Engine SDKから脱却した世界なので、これだけでは動かないと思う。
|
sinmetal
reviewed
Aug 16, 2019
| api_version: go1.9 | ||
| module: slackbot | ||
| runtime: go112 | ||
| module: default |
There was a problem hiding this comment.
moduleをdefaultに変えてしまうと、Deploy時に他のハンズオンのやつとぶつかるので、ちょっとあれかも？
There was a problem hiding this comment.
なるほど！このような場合にどのようにmoduleに名前をつけていいのかわからず、エラーメッセージの通りにdefaultに変更していました。
https://cloud.google.com/appengine/docs/standard/go112/config/appref
このドキュメントを読んだのですが、moduleについて書かれておらず、そもそもGo1.12ではmoduleの定義をyamlから外した方がいいのでしょうか？
There was a problem hiding this comment.
moduleはデプロイ先なので指定しないとdefaultにデプロイされてしまいます！
現在はmoduleはserviceに変わったので、以下のように設定するのが正しいと思います
service: slackbot
mom0tomo
force-pushed
the
update-go-version
branch
from
e19ed11 to
f423f5c
Compare
knsh14
reviewed
Aug 16, 2019
| w.WriteHeader(http.StatusInternalServerError) | ||
| } | ||
| return | ||
| default: | ||
| log.Errorf(ctx, "不正なアクション: %s", action) | ||
| log.Printf("不正なアクション: %s", action) |
There was a problem hiding this comment.
[IMO] ここだけログに出すメッセージが日本語なのが気になりました… invalid action とかのほうがいいかもしれません。
There was a problem hiding this comment.
@tenntenn こちらは英語メッセージにしたほうがよいでしょうか？
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
教材slackbotで使っているGAE Goのバージョンを1.12にアップデートし、go modulesを使ってパッケージの依存管理をする様に変更しました。