Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error for selecting dom during bookmark upload #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sushant-hiray
Copy link

@sushant-hiray sushant-hiray commented Nov 1, 2017

Fixes TypeError while performing bookmark upload:

Following is the console log:

(index):10152 Uncaught TypeError: Cannot read property 'select' of undefined
    at HTMLElement.b._uploadFile ((index):10152)
    at HTMLElement.d ((index):4668)
    at HTMLElement.fire ((index):4690)
    at Object.fire ((index):4678)
    at Object.forward ((index):4685)
    at Object.click ((index):4684)
    at HTMLElement.handleNative ((index):4674)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@sushant-hiray
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link

@shivaylamba shivaylamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflict @sushant-hiray

Copy link

@jded12345 jded12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants