Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(main/lesspipe): ship zsh completions #22658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomJo2000
Copy link
Member

lesspipe offers Zsh completions, these require zsh to be present on the host at build time though.

CC: @Biswa96

@TomJo2000 TomJo2000 requested a review from Grimler91 as a code owner December 22, 2024 20:10
@Biswa96
Copy link
Member

Biswa96 commented Dec 22, 2024

Could we consider the possibility of bypassing the zsh requirement? I would prefer to avoid adding unnecessary components to the host container.

@TomJo2000
Copy link
Member Author

TomJo2000 commented Dec 22, 2024

Yeah that's valid.
Unfortunately the --all-completions flag for configure doesn't bypass it.
(Could probably be considered a bug)

Adding a dummy zsh to $PATH didn't work in my testing either.
And I couldn't figure out what exactly would need patching in the configure script.
https://github.com/wofr06/lesspipe/blob/lesspipe/configure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants