Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: map tx events to the txInfo #68

Merged
merged 2 commits into from
Jan 25, 2024
Merged

feat: map tx events to the txInfo #68

merged 2 commits into from
Jan 25, 2024

Conversation

emidev98
Copy link
Contributor

This pull request maps three properties that weren't mapped before when quering the transaction info:

  • events: events emitted during tx execution including ANTE and POST,
  • info: additional tx information that can be indeterminisitc,
  • codespace: 0 if succeeded or non-zero error code,
  • data: proto encoded data to HEX type of the Msg.

Copy link

@mwmerz mwmerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Build seems to be failing due to linting. Do we care if this auto-builds? should we add ts-ignores if we want to leave those lint issues in?

@emidev98
Copy link
Contributor Author

emidev98 commented Jan 9, 2024

Thanks for the observation @mwmerz I think the issue is not actually linting but the tests, when I find some time I will try to fix all the failing tests. The problem is that these tests work agains the testnet and some of them will also need to be adjusted to the latest core upgrades

@emidev98 emidev98 merged commit a03e575 into main Jan 25, 2024
1 check failed
@emidev98 emidev98 deleted the feat/tx/events branch January 25, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants