fix: Issues with content filtering when using patterns #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohaibiftikhar
force-pushed
the
fix/filtering
branch
from
31db3c7 to
0b1c365
Compare
sohaibiftikhar
changed the title
sohaibiftikhar
changed the title
-- `ZipContentFilter` logic for patterns that have a single allowed pattern. Earlier this would include all files. -- `generate_content_hash` also considers the patterns before generating the hash so that the hash generated matches the content of the zip.
sohaibiftikhar
force-pushed
the
fix/filtering
branch
from
0b1c365 to
414fbb0
Compare
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--
ZipContentFilterlogic for patterns that have a single allowed pattern.Earlier this would include all files.
--
generate_content_hashalso considers the patterns before generating thehash so that the hash generated matches the content of the zip.
Motivation and Context
[ ".*.py$" ]will also include files that do not match that pattern.Breaking Changes
Unless someone is relying on the legacy behaviour this should not be a breaking change. It will however cause redeployments because of content hash changes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request