fix: Rename npm_package_json to npm_requirements #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This is not stale |
|
@antonbabenko can you give it a look please? |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Still a thing |
|
This PR has been automatically marked as stale because it has been open 30 days |
Signed-off-by: GitHub <[email protected]>
|
@antonbabenko friendly ping. Can you please give a look? Thank you |
antonbabenko
approved these changes
Jan 7, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Jan 7, 2025
## [7.17.1](v7.17.0...v7.17.1) (2025-01-07) ### Bug Fixes * Rename npm_package_json to npm_requirements ([#621](#621)) ([4bc61eb](4bc61eb))
|
This PR is included in version 7.17.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change was missed in #293. Documentation is up to date, code is not.
Fixes #506
Replace #507
Motivation and Context
This would solve inconsistencies in the documentation. It says the field is named
npm_requirements, but it's in factnpm_package_json.Breaking Changes
There is no breaking change. The wrongly documented field
npm_requirementswill start to work as expected. The previous non-documented fieldnpm_package_jsonwill keep working.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request