Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump required tf version to >= 1.9.0 #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ocofaigh
Copy link
Member

Description

In order to encourage the use of features that were added in terraform 1.9 (such as cross-object referencing for input variable validations) we are rolling out updates to all modules / DA to required terraform version to be >= 1.9.0 since this version is fully supported (and is the current default) in IBM Cloud Schematics.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh requested a review from argeiger as a code owner January 22, 2025 13:00
@ocofaigh
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Member Author

There seems to be an issue in the current main branch code. The upgrade test fails because the module.cloudpak_data.module.cloud_pak_deployer.null_resource.cloud_pak_deployer_security_context_constraint resource is always getting identified for destroy due to the fact it has a trigger on the oc login which is set to always run:

TestRunUpgradeExample 2025-01-22T14:05:22Z command.go:185:   # module.cloudpak_data.module.cloud_pak_deployer.null_resource.cloud_pak_deployer_security_context_constraint must be replaced
TestRunUpgradeExample 2025-01-22T14:05:22Z command.go:185: -/+ resource "null_resource" "cloud_pak_deployer_security_context_constraint" {
TestRunUpgradeExample 2025-01-22T14:05:22Z command.go:185:       ~ id       = "3840180669722243802" -> (known after apply)
TestRunUpgradeExample 2025-01-22T14:05:22Z command.go:185:       ~ triggers = { # forces replacement
TestRunUpgradeExample 2025-01-22T14:05:22Z command.go:185:           ~ "oc"                               = "oc --kubeconfig /tmp/terraform-base-cp4dup-kdud193364423139/solutions/deploy/88638e3d92b7ee9e0cf8c4c43cdd95820095aa81fba926eb161612c3cf161e04_cu8essdl0721akrem2ug_k8sconfig/config.yml" -> "oc --kubeconfig /tmp/terraform-pr-cp4dup-kdud19617590208/solutions/deploy/88638e3d92b7ee9e0cf8c4c43cdd95820095aa81fba926eb161612c3cf161e04_cu8essdl0721akrem2ug_k8sconfig/config.yml"
TestRunUpgradeExample 2025-01-22T14:05:22Z command.go:185:             # (3 unchanged elements hidden)
TestRunUpgradeExample 2025-01-22T14:05:22Z command.go:185:         }
TestRunUpgradeExample 2025-01-22T14:05:22Z command.go:185:     }

@argeiger I am assuming this is what you are addressing in #7 ? If so we can hold off merging this until that issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant