-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor:update the prefix logic in DA #565
base: main
Are you sure you want to change the base?
Conversation
/run pipeline |
/run pipeline |
Please find test reference . |
The TestRunStandardUpgradeSolution is failing due to the addition of a default value for the prefix variable. As per the test terraform will execute the following actions:
Since removing the prefix won't result in a breaking change for the user, So as per the discussion it is fine to skip the upgrade test in this scenario. |
/run pipeline |
/run pipeline |
/run pipeline |
Description
Refactored the code logic for prefix variable by adding default value for prefix and marked as required in catalog manifest.Also allowed prefix to be "" (empty string) for advanced users.
#11959
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Add the default value for prefix variable and mark as required in catalog manifest. Also allowed prefix to be "" (empty string ).The addition of a default value for the prefix variable has caused a failure in the TestRunStandardUpgradeSolution. However, if users remove the prefix, it will not result in a breaking change.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers