-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: git change detection works on any commit #1235
Draft
snakster
wants to merge
1
commit into
main
Choose a base branch
from
snk-git-change-detection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for terramate-io-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
snakster
force-pushed
the
snk-git-change-detection
branch
2 times, most recently
from
November 15, 2023 01:30
ab25e41
to
318124b
Compare
|
snakster
force-pushed
the
snk-git-change-detection
branch
7 times, most recently
from
November 20, 2023 09:47
123e97a
to
767bcf8
Compare
snakster
changed the title
fix: git change detection works on any commit
feat: git change detection works on any commit
Nov 20, 2023
i4ki
reviewed
Nov 20, 2023
snakster
force-pushed
the
snk-git-change-detection
branch
from
November 21, 2023 10:16
767bcf8
to
14158a3
Compare
mariux
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally tested the PR, please check the notion document for comments on a case this PR now creates wrong results when calculating changes.
snakster
force-pushed
the
snk-git-change-detection
branch
from
December 28, 2023 23:57
14158a3
to
d6d7d1d
Compare
✅ Deploy Preview for docs-terramate-io canceled.
|
snakster
force-pushed
the
snk-git-change-detection
branch
4 times, most recently
from
January 2, 2024 11:29
9b7088b
to
c6895ee
Compare
snakster
force-pushed
the
snk-git-change-detection
branch
2 times, most recently
from
January 11, 2024 14:10
ddfe460
to
99a1ed3
Compare
snakster
force-pushed
the
snk-git-change-detection
branch
from
March 22, 2024 17:23
99a1ed3
to
39f0dd0
Compare
snakster
force-pushed
the
snk-git-change-detection
branch
2 times, most recently
from
March 22, 2024 17:37
f9f3a79
to
9815ff7
Compare
snakster
force-pushed
the
snk-git-change-detection
branch
from
March 22, 2024 17:46
9815ff7
to
d3f17fc
Compare
snakster
force-pushed
the
snk-git-change-detection
branch
from
May 10, 2024 18:39
d3f17fc
to
04e123d
Compare
snakster
force-pushed
the
snk-git-change-detection
branch
from
May 10, 2024 18:40
04e123d
to
3c0d658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This Change
Currently, the Git revision that's used for change comparison with
terramate (run | list) --changed
is selected based on these rules (simplified):This means for the two cases of either getting a preview of a deployment, or executing the deployment, it will select the changed stacks relative to the previous deployment (w.r.t. to the commit graph).
For anything before origin/main, it will not select the changed stacks relative to the previous deployment, but the changed stacks compared to the latest deployment.
This is inconsistent, and more importantly, can lead to unintended behaviour in case of queued CI jobs that are behind origin/main when multiple PRs are merged in parallel.
Description of Changes
The selection logic for the compared base revision is changed so that "select the changed stacks relative to the previous deployment"-behaviour works on any commit.
Simplified, this means any commit is now compared its fork point from origin/main.