chore: optimize the format by using files from config tree. #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i4ki
force-pushed
the
i4k-optimize-fmt
branch
from
a815687 to
0ae792a
Compare
|
Signed-off-by: i4k <[email protected]>
i4ki
force-pushed
the
i4k-optimize-fmt
branch
from
0ae792a to
40e05cb
Compare
i4ki
changed the title
|
sixstone-qq
reviewed
Nov 20, 2024
| @@ -2404,6 +2406,7 @@ func (c *cli) gitSafeguardRemoteEnabled() bool { | |||
| } | |||
|
|
|||
| func (c *cli) wd() string { return c.prj.wd } | |||
| func (c *cli) wd2() prj.Path { return prj.PrjAbsPath(c.rootdir(), c.wd()) } | |||
There was a problem hiding this comment.
Why not more closely to what the function does?
Suggested change
| func (c *cli) wd2() prj.Path { return prj.PrjAbsPath(c.rootdir(), c.wd()) } | |
| func (c *cli) absPathWD() prj.Path { return prj.PrjAbsPath(c.rootdir(), c.wd()) } |
| @@ -1276,6 +1278,7 @@ var = [ | |||
| } | |||
|
|
|||
| func TestFormatHCL(t *testing.T) { | |||
| t.Skip("not yet") | |||
There was a problem hiding this comment.
Is this expected to be fixed in this PR?
There was a problem hiding this comment.
yes, I swear I marked this PR "draft" before leaving the PC yesterday 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Format the files from the configuration tree instead of re-scanning the filesystem.
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
Does this PR introduce a user-facing change?