Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

def: Fin as a record type #452

Merged
merged 3 commits into from
Jan 6, 2025
Merged

def: Fin as a record type #452

merged 3 commits into from
Jan 6, 2025

Conversation

plt-amy
Copy link
Member

@plt-amy plt-amy commented Jan 6, 2025

Reimplement Fin n as a pair of a natural k + an irrelevant proof that k < n, using a view to preserve the structure of pattern-matching proofs. A couple proofs need to appeal to the view for the coverage checker to see that only fzero is possible.

@plt-amy plt-amy requested a review from ncfavier January 6, 2025 18:05
@Lavenza
Copy link
Member

Lavenza commented Jan 6, 2025

Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

src/Data/Fin/Base.lagda.md Outdated Show resolved Hide resolved
src/Data/Fin/Base.lagda.md Outdated Show resolved Hide resolved
@plt-amy plt-amy merged commit 8d26384 into main Jan 6, 2025
5 checks passed
@plt-amy plt-amy deleted the aliao/record-fin branch January 6, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants