tidied up code

.luacheck_tidy

@@ -7,8 +7,9 @@ read_globals = {
 	"dump", "vector",
 	"VoxelManip", "VoxelArea",
 	"ItemStack", "PseudoRandom",
-	"stairsplus", "intllib",
-	"unified_inventory",
+	"intllib", "farming",
+	"stairs", "stairsplus",
+	"ingots", "unified_inventory",
 	math = { fields = {"sign"} },
 	table = { fields = {"copy"} }
 }

.luacheckrc

@@ -3,6 +3,8 @@ max_line_length = false
 read_globals = {
 	"default",
 	"dump",
+	"farming",
+	"ingots",
 	"intllib",
 	"ItemStack",
 	math = { fields = {"sign"} },

items/storage_tank.lua

@@ -133,7 +133,7 @@ function factory.register_storage_tank(name, increment, tiles, plaintile, light,
 		wield_image = "factory_storage_tank.png",
 		groups = {not_in_creative_inventory = 1},
 		stack_max = 1,
-		on_place = function(itemstack, placer, pointed_thing)
+		on_place = function(itemstack, _, pointed_thing)
 			if not pointed_thing or pointed_thing.type ~= "node" then
 				return
 			end

machines/crafting.lua

@@ -43,9 +43,9 @@ minetest.register_craft({
 minetest.register_craft( {
 	output = "factory:autocrafter",
 	recipe = {
-	        { "factory:factory_brick", "factory:factory_brick", "factory:factory_brick" },
-	        { "factory:small_diamond_gear", "default:steel_ingot", "factory:small_diamond_gear" },
-	        { "factory:factory_brick", "factory:factory_brick", "factory:factory_brick" }
+		{ "factory:factory_brick", "factory:factory_brick", "factory:factory_brick" },
+		{ "factory:small_diamond_gear", "default:steel_ingot", "factory:small_diamond_gear" },
+		{ "factory:factory_brick", "factory:factory_brick", "factory:factory_brick" }
 	},
 })
 
@@ -67,7 +67,7 @@ minetest.register_craft({
 minetest.register_craft({
 	type = "shapeless",
 	output = "factory:taker_diamond",
-	recipe = {"factory:taker_gold", "factory:small_diamond_gear"}  --"default:diamondblock"
+	recipe = {"factory:taker_gold", "factory:small_diamond_gear"} --"default:diamondblock"
 })
 
 minetest.register_craft({
@@ -101,12 +101,12 @@ minetest.register_craft({
 })
 
 minetest.register_craft({
-  output = "factory:grinder",
-  recipe = {
-    {"default:stonebrick",  "default:stonebrick", "default:stonebrick"},
-    {"factory:small_diamond_gear", "",    "factory:small_diamond_gear"},
-    {"default:stonebrick",  "default:furnace",    "default:stonebrick"}
-  }
+	output = "factory:grinder",
+	recipe = {
+		{"default:stonebrick",  "default:stonebrick", "default:stonebrick"},
+		{"factory:small_diamond_gear", "",    "factory:small_diamond_gear"},
+		{"default:stonebrick",  "default:furnace",    "default:stonebrick"}
+	}
 })
 
 minetest.register_craft({
@@ -170,13 +170,13 @@ minetest.register_craft({
 })
 
 if factory.setting_enabled("StpCraft") then
-  minetest.register_craft({
-  	output = "factory:stp",
-  	recipe = {
-  		{ "factory:factory_brick", "factory:small_diamond_gear", "factory:factory_brick" },
-  		{ "default:glass",         "default:dirt",               "factory:factory_brick" },
-  		{ "factory:factory_brick", "default:mese_crystal",        "factory:factory_brick" }
-  	}
-  })
+	minetest.register_craft({
+		output = "factory:stp",
+		recipe = {
+			{ "factory:factory_brick", "factory:small_diamond_gear", "factory:factory_brick" },
+			{ "default:glass",         "default:dirt",               "factory:factory_brick" },
+			{ "factory:factory_brick", "default:mese_crystal",        "factory:factory_brick" }
+		}
+	})
 end
 -- vim: et:ai:sw=2:ts=2:fdm=indent:syntax=lua

machines/vacuum.lua

@@ -99,7 +99,8 @@ minetest.register_abm({
 	neighbors = nil,
 	interval = 1,
 	chance = 1,
-	action = function(pos, node, _, aocw)
+  -- pos, node, active_object_count, active_object_count_wider
+	action = function(pos, _, _, aocw)
 		if aocw == 0 then return end
 		local all_objects = factory.get_objects_with_square_radius({x = pos.x, y = pos.y + 3, z = pos.z}, 2)
 		for _,obj in ipairs(all_objects) do