[WIP] added csv to json for javascript

[veeralsharma]

added functionality for converting csv to json , just added the location of your file in path and you are good to go

[thealphadollar]

Hey, @veeralsharma Thank you very much for your contributions. I'm glad you invested time in making the project better. The script runs fine, and there are few more changes we can work on before I merge this.

Output format

The current output of the script is

[{"vanilla-i18n-key":"language","English":"Language","हिन्दी":"भाषा","española":"idioma","français\r":"Langue\r"},{"vanilla-i18n-key":"form.name","English":"Name","हिन्दी":"नाम","española":"nombre","français\r":"Nom\r"},{"vanilla-i18n-key":"form.age","English":"Age","हिन्दी":"उम्र","española":"años","français\r":"âge\r"},{"vanilla-i18n-key":"form.resp.yes","English":"Yes","हिन्दी":"हाँ","española":"si","français\r":"Oui"}]

However, the desired output format is in a file, one file for each language, in a folder vanilla-i18n. For example, the english.json and français.json after running the script on example.csv should have the following:

{"language":"Language","form":{"name":"Name","age":"Age","resp":{"yes":"Yes"}}}

{"language":"Langue","form":{"name":"Nom","age":"\u00e2ge","resp":{"yes":"Oui"}}}

Readme Updates

Since you are adding a new script, you may also want to update the README.md inside csv_to_vanilla_i18n folder to include information about your created script - take a look at existing information about the python script for inspiration.

Other Minor Changes

I've commented on the lines/sections of code where I had to provide suggestions, please see if you can consider them 💯

Let's together make the PR better and then merge it, it would be an ama

[veeralsharma]

thanks brother for your comments and considering me to work further on this repo although, i wont be able to do this in a while due to some personal issues you can merge this for now and ill surely correct these pointsnin future you can merge pr and let these issues assigned ill work it in another pr in some days if thats okay with you

…

On Sat, 3 Oct, 2020, 11:02 pm Shivam Kumar Jha, ***@***.***> wrote: Assigned #4 <#4> to @veeralsharma <https://github.com/veeralsharma>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKOBPZ5MCX4QAN4KJ76PYPLSI5N2JANCNFSM4SCWKN6Q> .

[thealphadollar]

Hey Veeral, I'm afraid I cannot merge the PR in the current state since the script would mislead users. I totally understand and feel free to contribute as you are comfortable.

I'm making this a draft PR for the time being 😄

[veeralsharma]

sure no problem

…

On Sun, 4 Oct, 2020, 12:10 am Shivam Kumar Jha, ***@***.***> wrote: Hey Veeral, I'm afraid I cannot merge the PR in the current state since the script would mislead users. I totally understand and feel free to contribute as you are comfortable. I'm making this a draft PR for the time being 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKOBPZZBXK2XKNB6F6V6G53SI5VZ3ANCNFSM4SCWKN6Q> .

[veeralsharma]

dont put it in draft it kinda affect the whole hacktober fest thing , if possible merge it I don't think so it will mislead anyone now

[thealphadollar]

Hey @veeralsharma , I understand that you want to finish the hacktoberfest 4 PRs. However, I'm afraid I cannot accept a script that cannot be used - it'll mislead people to think that we have a node.js script and when they'll use it, the output will be different from what we accept and can be used with vanilla-i18n.

I understand your skills, and if you have written the script, I believe you can modify it to match the output format and structure so that I can quickly accept it. If completed this will be really useful for web developers :D

PS. A small note of humble request, please do not convert to "ready for review" if a maintainer marks it as "draft". It might come out as rude and spam 😄

[thealphadollar]

@veeralsharma Please let me know if you'd be continuing work on the PR - although the feature has been added since you have worked on it, I'll accept the PR if we can incorporate the requested changes.

[veeralsharma]

ill make the changes tomorrow for sure, thanks alot

…

On Sun, 11 Oct, 2020, 9:59 pm Shivam Kumar Jha, ***@***.***> wrote: @veeralsharma <https://github.com/veeralsharma> Please let me know if you'd be continuing work on the PR - although the feature has been added since you have worked on it, I'll accept the PR if we can incorporate the requested changes. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKOBPZ4SZ7D5PAO4EGBZMTLSKHMOJANCNFSM4SCWKN6Q> .

[veeralsharma]

Hey everything is done from my side
I have incorporated all the changes you asked

[thealphadollar]

@veeralsharma Hey thanks for the update. Can you please confirm that the output on running the script on example.csv is same as available in the existing folder vanilla-i18n in the script folder

[veeralsharma]

I have corrected some things , and tested out completely and now it runs exactly how it is supposed to , you can check

[thealphadollar]

Hey @veeralsharma Since this is a copy of https://github.com/thealphadollar/vanilla-i18n/blob/master/csv_to_vanilla-i18n/csv_to_vanilla_i18.js, I'm marking it as hacktoberfest-invalid. It made me really sad that you chose to duplicate the file at the end instead of improving your submission.

[veeralsharma]

okay , you can do that but this isnt a copy from there but what i found on stack overflow while researching no problem , i still learned one or two things while doing this thanks

…

On Mon, 12 Oct, 2020, 11:28 pm Shivam Kumar Jha, ***@***.***> wrote: ***@***.**** commented on this pull request. Hey @veeralsharma <https://github.com/veeralsharma> Since this is a copy of https://github.com/thealphadollar/vanilla-i18n/blob/master/csv_to_vanilla-i18n/csv_to_vanilla_i18.js, I'm marking it as hacktoberfest-invalid. It made me really sad that you chose to duplicate the file at the end instead of improving your submission. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKOBPZYKW4GHNREGCJFPK3DSKM7SRANCNFSM4SCWKN6Q> .

[thealphadollar]

That's a good attitude @veeralsharma . All the best for future contributions ✨

[veeralsharma]

same to you

…

On Mon, 12 Oct, 2020, 11:33 pm Shivam Kumar Jha, ***@***.***> wrote: That's a good attitude @veeralsharma <https://github.com/veeralsharma> . All the best for future contributions ✨ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKOBPZ4DBFZEYNUJUWVX67DSKNAITANCNFSM4SCWKN6Q> .