switch Jenkins to use Java 17 #2195
Merged
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
jenkins-java-17
branch
from
c9c2ab2 to
d06eb5a
Compare
|
Jenkins upstream would support Java 21, but there is no 21 in Debian (old)stable. |
evgeni
commented
Jan 6, 2025
Comment on lines
-26
to
+28
| $java_package = 'java-11-openjdk-headless' | ||
| $java_package = 'java-17-openjdk-headless' | ||
|
|
||
| package { ['java-1.8.0-openjdk', 'java-1.8.0-openjdk-headless', 'java-1.8.0-openjdk-devel']: | ||
| package { ['java-11-openjdk', 'java-11-openjdk-headless', 'java-11-openjdk-devel']: |
There was a problem hiding this comment.
I was wondering if we should have jenkins_java_version = 17 and jenkins_java_cleanup = 11 somewhere, and just reuse that through the manifests.
evgeni
force-pushed
the
jenkins-java-17
branch
from
d06eb5a to
0c7333e
Compare
ekohl
approved these changes
Jan 7, 2025
| @@ -4,14 +4,10 @@ | |||
| auto => { 'reboot' => false }, | |||
| blacklist => [ | |||
| 'docker-ce', | |||
There was a problem hiding this comment.
Unrelated, but we can get rid of this by now. We never really adopted Docker on our CI.
There was a problem hiding this comment.
Especially, we do not have Debian-based (general purpose) CI nodes ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.