Use automatic compression based on file path for tar #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way users can pass .tar.xz to get XZ compression too. One side effect is that by default we won't compress anymore since the file extension is .tar. On the other hand, it's less confusing for users that you have a .tar extension which should be .tar.gz.
ekohl
force-pushed
the
use-auto-compression
branch
from
bb61184 to
bf636a5
Compare
evgeni
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way users can pass .tar.xz to get XZ compression too. One side effect is that by default we won't compress anymore since the file extension is .tar. On the other hand, it's less confusing for users that you have a .tar extension which should be .tar.gz.
This was noted in https://bugzilla.redhat.com/show_bug.cgi?id=1874045#c5. Right now this is a draft because I think we first need to have a discussion on whether this is correct. Note
certs::tar_extractalready has-aso it should pick it up already.