Skip to content

Commit

Permalink
Correct git log in issue verification (#320)
Browse files Browse the repository at this point in the history
Only the first line counts. This avoids flaggin where a commit contains
'something fixes #1234' somewhere in the description. A common way this
is included is the `Fixes: commitsha ("commit description")`.
  • Loading branch information
ekohl authored Dec 5, 2023
1 parent e3693a3 commit f9470e3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion issues
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ end
current_release_name = ARGV[1]
prev_release_name = ARGV[2]

git_issues = Set.new(`git log #{prev_release_name}.. | grep -i fixes | egrep -o \"[ ,]#[0-9]*\" | sed -e 's/[ ,]#//g'`.split.map(&:to_i))
git_issues = Set.new(`git log --oneline #{prev_release_name}.. | grep -i fixes | grep -E -o \"[ ,]#[0-9]*\" | sed -e 's/[ ,]#//g'`.split.map(&:to_i))

def url_to_json(uri)
response = Net::HTTP.get(uri)
Expand Down

0 comments on commit f9470e3

Please sign in to comment.