updater.go: replace os.WriteFile with file.Write() (#669)

* Update updater.go replace os.WriteFile with file.Write() Signed-off-by: udf2457 <[email protected]> * Update metadata/updater/updater.go File is closed on all branches in the code, removing this. Signed-off-by: Fredrik Skogman <[email protected]> --------- Signed-off-by: udf2457 <[email protected]> Signed-off-by: Fredrik Skogman <[email protected]> Co-authored-by: Fredrik Skogman <[email protected]>
theupdateframework · Jan 22, 2025 · 110bec9 · 110bec9
1 parent 830edf8
commit 110bec9
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/metadata/updater/updater.go b/metadata/updater/updater.go
@@ -596,11 +596,22 @@ func (update *Updater) persistMetadata(roleName string, data []byte) error {
 	if err != nil {
 		return err
 	}
-	defer file.Close()
+	// change the file permissions to our desired permissions
+	err = file.Chmod(0644)
+	if err != nil {
+		// close and delete the temporary file if there was an error while writing
+		file.Close()
+		errRemove := os.Remove(file.Name())
+		if errRemove != nil {
+			log.Info("Failed to delete temporary file", "name", file.Name())
+		}
+		return err
+	}
 	// write the data content to the temporary file
-	err = os.WriteFile(file.Name(), data, 0644)
+	_, err = file.Write(data)
 	if err != nil {
-		// delete the temporary file if there was an error while writing
+		// close and delete the temporary file if there was an error while writing
+		file.Close()
 		errRemove := os.Remove(file.Name())
 		if errRemove != nil {
 			log.Info("Failed to delete temporary file", "name", file.Name())