Remove readFile() and reverseSlice() in favour of stdlib #671
+7
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove readFile() as it appears to essentially be a re-implementation of stdlib's os.ReadFile Signed-off-by: udf2457 <[email protected]>
Another instance of re-implementing os.ReadFile. This one does not even appear to be used by the cli code. Signed-off-by: udf2457 <[email protected]>
Reference os.Readfile instead of the re-implementation Signed-off-by: udf2457 <[email protected]>
Remove ReadFile re-implementation Signed-off-by: udf2457 <[email protected]>
udf2457
changed the title
Don't reinvent the wheel, use stdlib os.ReadFile 😉 Signed-off-by: udf2457 <[email protected]>
udf2457
changed the title
Remive the reimplementation of stdlib slices.Reverse() Signed-off-by: udf2457 <[email protected]>
udf2457
changed the title
udf2457
changed the title
|
I see the test failed on Easily fixed, I'll remove the |
remove un-necessary io import Signed-off-by: udf2457 <[email protected]>
|
Can you try re-running the test, Apologies for missing that ! |
Remove io import Signed-off-by: udf2457 <[email protected]>
kommendorkapten
approved these changes
Jan 24, 2025
mnm678
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propose removing
readFile()fromupdater.goas it appears to essentially be a re-implementation of stdlib'sos.ReadFileAlso found a "hidden" re-implementation of
os.ReadFilein metadata.go, so changed that toos.ReadFiletoo.Also found the re-implementation of
os.Readfileincli/tuf/cmd/root.go, so changed that toos.ReadFiletoo.Also found a re-implementation of
os.ReadFileincli/tuf-client/cmd/root.gowhere it appears completely unused ?Also
reverseSlice()inmetadata/updater/updater.goseems to be a reimplementation of stdlib'sslices.Reverse()so removed that too.Phew... I think that's all of them. 😆